Skip to content

refactor(setup): migrate SetupData handling to guira dependency#103

Merged
Joltras merged 18 commits into
mainfrom
feature/setupDataSwap
Jun 28, 2026
Merged

refactor(setup): migrate SetupData handling to guira dependency#103
Joltras merged 18 commits into
mainfrom
feature/setupDataSwap

Conversation

@Joltras

@Joltras Joltras commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Proposed changes

Since some versions, the codebase contained two different approaches to handle SetupData during a setup. This change removes the old approach and'fully integrates the guira dependency throughout the setup module.

It is now possible for more than one player to set up a map concurrently, though the number of players per map remains limited to one.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Joltras Joltras self-assigned this Jun 28, 2026
@Joltras Joltras added the area: setup Everything related to the the setup module label Jun 28, 2026
@Joltras

Joltras commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator Author

After the merge of this pull request the setup remains non-functional. Some commands still rely on the old implementation and require migration to the new one

@Joltras Joltras merged commit 202b1f6 into main Jun 28, 2026
2 of 5 checks passed
@Joltras Joltras deleted the feature/setupDataSwap branch June 28, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: setup Everything related to the the setup module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant